lokeshj1703 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2085323500
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSourceHarness.java:
##########
@@ -223,10 +224,7 @@ protected Pair<String, List<HoodieRecord>>
writeS3MetadataRecords(String commitT
generateS3EventMetadata(commitTime, "bucket-1", "data-file-1.json",
1L)
);
JavaRDD<WriteStatus> result =
writeClient.upsert(jsc().parallelize(s3MetadataRecords, 1), commitTime);
-
- List<WriteStatus> statuses = result.collect();
- assertNoWriteErrors(statuses);
-
+ writeClient.commit(commitTime, result, Option.empty(), COMMIT_ACTION,
Collections.emptyMap(), Option.empty());
Review Comment:
Addressed
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestIncrSourceHelper.java:
##########
@@ -342,11 +340,7 @@ private Pair<String, List<HoodieRecord>>
writeS3MetadataRecords(String commitTim
List<HoodieRecord> s3MetadataRecords = Arrays.asList(
generateS3EventMetadata(commitTime, "bucket-1", "data-file-1.json",
1L)
);
- JavaRDD<WriteStatus> result =
writeClient.upsert(jsc().parallelize(s3MetadataRecords, 1), commitTime);
-
- List<WriteStatus> statuses = result.collect();
- assertNoWriteErrors(statuses);
-
+ writeClient.commit(commitTime,
writeClient.upsert(jsc().parallelize(s3MetadataRecords, 1), commitTime));
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/feature/index/TestExpressionIndex.scala:
##########
@@ -2304,6 +2304,7 @@ class TestExpressionIndex extends HoodieSparkSqlTestBase {
private def getWriteConfigBuilder(hudiOpts: Map[String, String], basePath:
String): HoodieWriteConfig.Builder = {
val props =
TypedProperties.fromMap(JavaConverters.mapAsJavaMapConverter(hudiOpts).asJava)
HoodieWriteConfig.newBuilder()
+
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java:
##########
@@ -1014,14 +1018,9 @@ void
testInsertsGeneratedIntoLogFilesRollbackAfterCompaction(boolean rollbackUsi
// Do a compaction
newCommitTime =
writeClient.scheduleCompaction(Option.empty()).get().toString();
HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata =
writeClient.compact(newCommitTime);
- statuses = compactionMetadata.getWriteStatuses();
- // Ensure all log files have been compacted into base files
- String extension = table.getBaseFileExtension();
- Collection<List<HoodieWriteStat>> stats =
compactionMetadata.getCommitMetadata().get().getPartitionToWriteStats().values();
- assertEquals(numLogFiles,
stats.stream().flatMap(Collection::stream).filter(state ->
state.getPath().contains(extension)).count());
- assertEquals(numLogFiles,
stats.stream().mapToLong(Collection::size).sum());
-
- //writeClient.commitCompaction(newCommitTime, statuses, Option.empty());
+ writeClient.commitCompaction(newCommitTime, compactionMetadata,
Option.empty());
+
assertTrue(metaClient.reloadActiveTimeline().filterCompletedInstants().containsInstant(newCommitTime));
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
