the-other-tim-brown commented on code in PR #13269:
URL: https://github.com/apache/hudi/pull/13269#discussion_r2094160369
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieClient.java:
##########
@@ -88,7 +89,14 @@ protected BaseHoodieClient(HoodieEngineContext context,
HoodieWriteConfig client
}
protected BaseHoodieClient(HoodieEngineContext context, HoodieWriteConfig
clientConfig,
- Option<EmbeddedTimelineService> timelineServer) {
+ Option<EmbeddedTimelineService> timelineServer) {
+ this(context, clientConfig, timelineServer, new
TransactionManager(clientConfig,
HoodieStorageUtils.getStorage(clientConfig.getBasePath(),
context.getStorageConf())),
+ TimeGenerators.getTimeGenerator(clientConfig.getTimeGeneratorConfig(),
context.getStorageConf()));
Review Comment:
I'm going to move the transaction manager and time generator instance
construction into some methods so it reads better and is easier to read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
