the-other-tim-brown commented on code in PR #13314:
URL: https://github.com/apache/hudi/pull/13314#discussion_r2094165679
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -423,8 +410,8 @@ protected Pair<Boolean, T> merge(BufferedRecord<T>
olderRecord, BufferedRecord<T
// TODO(HUDI-7843): decouple the merging logic from the merger
// and use the record merge mode to control how to merge partial updates
Option<Pair<HoodieRecord, Schema>> mergedRecord =
recordMerger.get().partialMerge(
- readerContext.constructHoodieRecord(olderRecord),
readerContext.getSchemaFromBufferRecord(olderRecord),
- readerContext.constructHoodieRecord(newerRecord),
readerContext.getSchemaFromBufferRecord(newerRecord),
+ readerContext.constructHoodieRecord(olderRecord, partitionPath),
readerContext.getSchemaFromBufferRecord(olderRecord),
+ readerContext.constructHoodieRecord(newerRecord, partitionPath),
readerContext.getSchemaFromBufferRecord(newerRecord),
Review Comment:
Actually, looking into the current class I see that there is `hasLogFiles`
which implies the class is currently going to only work per file slice so I
will move the partition path to keep the api the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
