wombatu-kun commented on code in PR #12772: URL: https://github.com/apache/hudi/pull/12772#discussion_r2094766763
########## hudi-spark-datasource/hudi-spark4-common/pom.xml: ########## @@ -0,0 +1,258 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>hudi-spark-datasource</artifactId> + <groupId>org.apache.hudi</groupId> + <version>1.1.0-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>hudi-spark4-common</artifactId> Review Comment: > Do we need a separate `hudi-spark4-common` module? If almost all classes are shared with Spark 3 (`hudi-spark3-common`), it's better to move the shared classes to `hudi-spark-common` and move the rest to Spark 4.0 module. Many classes are shared but not all. I'll try to avoid code duplication, but the `hudi-spark4-common` module is better to create right now at least as a foundation for the future (as 4.0 will not be the only version in Spark 4.x-generation, so it will be useful later). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
