the-other-tim-brown commented on PR #13320: URL: https://github.com/apache/hudi/pull/13320#issuecomment-2892565391
> > Moves the iterator initialization to the constructor so that developers do not need multiple calls to initialize the readers > > -1 for this, it's not a good practice to put such heavy work in the consructor. Maybe we should have a `open` method for the FG reader and move it there, the `open` corresponds to the `close`. @danny0405 another option is to move this into the call to get the iterator, would that be better? I want to avoid 3 calls to just get an iterator (construct, init, getIter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
