[
https://issues.apache.org/jira/browse/HUDI-9285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Chen closed HUDI-9285.
----------------------------
Reviewers: Danny Chen
Resolution: Fixed
Fixed via master branch: 38907ba527033ccb35d615a80065b6c6590da68d
> Add builder pattern to instantiate FG reader
> --------------------------------------------
>
> Key: HUDI-9285
> URL: https://issues.apache.org/jira/browse/HUDI-9285
> Project: Apache Hudi
> Issue Type: Sub-task
> Components: reader-core
> Reporter: sivabalan narayanan
> Assignee: Timothy Brown
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.1.0
>
>
> We have too many arguments for FG reader.
> {code:java}
> public HoodieFileGroupReader(HoodieReaderContext<T> readerContext,
> HoodieStorage storage, String tablePath,
> String latestCommitTime, FileSlice fileSlice,
> Schema dataSchema, Schema requestedSchema,
> Option<InternalSchema> internalSchemaOpt,
> HoodieTableMetaClient hoodieTableMetaClient, TypedProperties props,
> long start, long length, boolean
> shouldUseRecordPosition, boolean allowInflightInstants) { {code}
> Its high time we add a builder pattern to it and set defaults as well
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
