danny0405 commented on code in PR #13316:
URL: https://github.com/apache/hudi/pull/13316#discussion_r2101383736
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/ConcurrentOperation.java:
##########
@@ -84,6 +86,38 @@ public ConcurrentOperation(HoodieInstant instant,
HoodieCommitMetadata commitMet
init(instant);
}
+ /**
+ * Construct a ConcurrentOperation object for a compaction plan that is not
yet persisted to the timeline.
+ * This is used to detect potential conflicts with other operations.
+ * @param compactionPlan the potential compaction plan
+ * @param requestedInstantTime the requested instant time for the compaction
+ */
+ public ConcurrentOperation(HoodieCompactionPlan compactionPlan, String
requestedInstantTime) {
+ this.commitMetadataOption = Option.empty();
+ this.metadataWrapper = null;
Review Comment:
Let's move the `metadataWrapper` to be a local variable used only for
`#init` purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
