yihua commented on code in PR #13313:
URL: https://github.com/apache/hudi/pull/13313#discussion_r2103268242
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -251,15 +257,52 @@ public static HoodieIndex
createUserDefinedIndex(HoodieWriteConfig config) {
*/
private static <R> HoodieData<HoodieRecord<R>> getExistingRecords(
HoodieData<Pair<String, String>> partitionLocations, HoodieWriteConfig
config, HoodieTable hoodieTable) {
- final Option<String> instantTime = hoodieTable
- .getMetaClient()
+ HoodieTableMetaClient metaClient = hoodieTable.getMetaClient();
+ final Option<String> instantTime = metaClient
.getActiveTimeline() // we need to include all actions and completed
.filterCompletedInstants()
.lastInstant()
.map(HoodieInstant::requestedTime);
- return partitionLocations.flatMap(p
- -> new HoodieMergedReadHandle(config, instantTime, hoodieTable,
Pair.of(p.getKey(), p.getValue()))
- .getMergedRecords().iterator());
+ ReaderContextFactory<R> readerContextFactory =
hoodieTable.getContext().getReaderContextFactory(metaClient);
+ if (instantTime.isEmpty()) {
+ return hoodieTable.getContext().emptyHoodieData();
+ }
+ return partitionLocations.flatMap(p -> {
+ Option<FileSlice> fileSliceOption = Option.fromJavaOptional(hoodieTable
+ .getHoodieView()
+ .getLatestMergedFileSlicesBeforeOrOn(p.getLeft(), instantTime.get())
+ .filter(fileSlice -> fileSlice.getFileId().equals(p.getRight()))
Review Comment:
We can keep this logic as it is the same as before. The main thing I was
concerned about is the requests to timeline server (this file group reading
logic happens on executors) and the response per (partition, file ID).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
