the-other-tim-brown commented on code in PR #13290:
URL: https://github.com/apache/hudi/pull/13290#discussion_r2103634212
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2942,6 +2950,22 @@ public int getSecondaryIndexParallelism() {
return metadataConfig.getSecondaryIndexParallelism();
}
+ /**
+ * Whether to enable Optimized writes or not. By default for table version 6
we are not enabling this, since NBCC is not available in table version 6.
Review Comment:
Is there a concise way to explain why NBCC is required?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2942,6 +2950,22 @@ public int getSecondaryIndexParallelism() {
return metadataConfig.getSecondaryIndexParallelism();
}
+ /**
+ * Whether to enable Optimized writes or not. By default for table version 6
we are not enabling this, since NBCC is not available in table version 6.
+ * For flink and java engines, there are no issues w/ task retries and so
they are out of it.
Review Comment:
`they are out of it` is not clear. Is it simply `flink and java do not have
a need for this feature since the do not have task retries`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
