linliu-code commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r2105259264
##########
hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/hfile/HFileBootstrapIndexWriter.java:
##########
@@ -196,15 +189,11 @@ public void close() {
@Override
public void begin() {
try {
- HFileContext meta = new HFileContextBuilder().withCellComparator(new
org.apache.hudi.common.bootstrap.index.HFileBootstrapIndex.HoodieKVComparator()).build();
- this.indexByPartitionWriter =
HFile.getWriterFactory(metaClient.getStorageConf().unwrapAs(Configuration.class),
- new
CacheConfig(metaClient.getStorageConf().unwrapAs(Configuration.class)))
- .withPath((FileSystem) metaClient.getStorage().getFileSystem(), new
Path(indexByPartitionPath.toUri()))
- .withFileContext(meta).create();
- this.indexByFileIdWriter =
HFile.getWriterFactory(metaClient.getStorageConf().unwrapAs(Configuration.class),
- new
CacheConfig(metaClient.getStorageConf().unwrapAs(Configuration.class)))
- .withPath((FileSystem) metaClient.getStorage().getFileSystem(), new
Path(indexByFileIdPath.toUri()))
- .withFileContext(meta).create();
+ HFileContext context = HFileContext.builder().build();
Review Comment:
Sounds like `org.apache.hadoop.hbase.util.Bytes.ByteArrayComparator` should
work since it compares two byte arrays without interpreting the underlying
bytes and this is what we do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
