danny0405 commented on PR #13242: URL: https://github.com/apache/hudi/pull/13242#issuecomment-2906299812
I see some negative changs that I don't really like: unnecessary overhead: 1. `BufferedRecord#forRecordWithContext` -> `readerContext.convertValueToEngineType(orderingValue)` unnecessary complexity exposed: 1. `KeyBasedFileGroupRecordBuffer#processNextDataRecord` -> `!existing.equals(merged)`, `enablePartialMerging` 2. `FileGroupRecordBuffer#hasNextBaseRecord` -> `readerContext.projectRecord(` interface that does not make sense: 1. `BufferedRecord#asDeleteRecord` 2. `EngineBasedMerger#getLatestAsDeleteRecord` Maybe we just put the merging related logic together and does not touch the logic/interface change as of now, so you can test each of them separately. 1. `FileGroupRecordBuffer#merge`; 2. `FileGroupRecordBUffer#doProcessNextDataRecord`; 3. `FileGroupRecordBUffer#doProcessNextDeletedRecord`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
