bvaradar commented on a change in pull request #2249:
URL: https://github.com/apache/hudi/pull/2249#discussion_r521886663
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -273,7 +273,8 @@ public WriteStatus close() {
insertRecordsWritten++;
}
}
- keyToNewRecords.clear();
+
+ ((ExternalSpillableMap) keyToNewRecords).close();
Review comment:
merge handle seems to be the place where deleting on jvm shutdown would
be a problem. In other cases, they are fairly long lived.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -273,7 +273,8 @@ public WriteStatus close() {
insertRecordsWritten++;
}
}
- keyToNewRecords.clear();
+
+ ((ExternalSpillableMap) keyToNewRecords).close();
Review comment:
merge handle seems to be the only place where deleting on jvm shutdown
would be a problem. In other cases, they are fairly long lived.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
