danny0405 commented on code in PR #13192:
URL: https://github.com/apache/hudi/pull/13192#discussion_r2105670902


##########
hudi-common/src/main/java/org/apache/hudi/common/util/CleanerUtils.java:
##########
@@ -168,10 +168,18 @@ public static Option<HoodieInstant> 
getEarliestCommitToRetain(
   public static HoodieCleanerPlan getCleanerPlan(HoodieTableMetaClient 
metaClient, HoodieInstant cleanInstant)
       throws IOException {
     CleanPlanMigrator cleanPlanMigrator = new CleanPlanMigrator(metaClient);
+    cleanInstant = getCleanRequestInstant(metaClient, cleanInstant);

Review Comment:
   > Can we check all the callers of it, I see several places have already do 
some pre-transformation to make sure the instant is a REQUESTED before calling 
it.
   
   do we remove the unnecessary requested instant creation before the 
invocation of the method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to