linliu-code commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r2105709365
##########
hudi-io/src/main/java/org/apache/hudi/io/hfile/HFileBlock.java:
##########
@@ -187,34 +162,161 @@ public int getOnDiskSizeWithHeader() {
* @throws IOException upon decoding and decompression error.
*/
public void unpack() throws IOException {
- if (!isUnpacked) {
+ if (!readAttributesOpt.get().isUnpacked) {
// Should only be called for compressed blocks
CompressionCodec compression = context.getCompressionCodec();
if (compression != CompressionCodec.NONE) {
// Copy the block header which is not compressed
System.arraycopy(
- compressedByteBuff, startOffsetInCompressedBuff, byteBuff, 0,
HFILEBLOCK_HEADER_SIZE);
+ readAttributesOpt.get().compressedByteBuff,
+ readAttributesOpt.get().startOffsetInCompressedBuff,
+ readAttributesOpt.get().byteBuff,
+ 0,
+ HFILEBLOCK_HEADER_SIZE);
try (InputStream byteBuffInputStream = new ByteArrayInputStream(
- compressedByteBuff, startOffsetInCompressedBuff +
HFILEBLOCK_HEADER_SIZE, onDiskSizeWithoutHeader)) {
+ readAttributesOpt.get().compressedByteBuff,
+ readAttributesOpt.get().startOffsetInCompressedBuff +
HFILEBLOCK_HEADER_SIZE,
+ readAttributesOpt.get().onDiskSizeWithoutHeader)) {
context.getDecompressor().decompress(
byteBuffInputStream,
- byteBuff,
+ readAttributesOpt.get().byteBuff,
HFILEBLOCK_HEADER_SIZE,
- byteBuff.length - HFILEBLOCK_HEADER_SIZE);
+ readAttributesOpt.get().byteBuff.length -
HFILEBLOCK_HEADER_SIZE);
}
}
- isUnpacked = true;
+ readAttributesOpt.get().isUnpacked = true;
}
}
+ // ================ Below are for Write ================
+
/**
- * Allocates new byte buffer for the uncompressed bytes.
- *
- * @return a new byte array based on the size of uncompressed data, holding
the same header
- * bytes.
+ * Returns serialized "data" part of the block.
+ * This function should be implemented by each block type separately.
+ * By default, it does nothing.
+ */
+ public ByteBuffer getPayload() {
+ return ByteBuffer.allocate(0);
+ }
+
+ /**
+ * Return serialized block including header, data, checksum.
+ */
+ public ByteBuffer serialize() throws IOException {
+ // Block payload.
+ ByteBuffer payloadBuff = getPayload();
+ // Compress if specified.
+ ByteBuffer compressedPayload = compress(payloadBuff);
+ // Buffer for building block.
+ ByteBuffer buf = ByteBuffer.allocate(Math.max(
+ context.getBlockSize() * 2,
+ compressedPayload.limit() + HFILEBLOCK_HEADER_SIZE * 2));
+ // Block header
+ // 1. Magic is always 8 bytes.
+ buf.put(blockType.getMagic(), 0, 8);
+ // 2. onDiskSizeWithoutHeader.
+ buf.putInt(compressedPayload.limit());
+ // 3. uncompressedSizeWithoutHeader.
+ buf.putInt(payloadBuff.limit());
+ // 4. previous block offset.
+ buf.putLong(writeAttributesOpt.get().previousBlockOffset);
+ // TODO: set checksum type properly.
+ // 5. checksum type.
+ buf.put(CHECKSUM_TYPE.getCode());
+ // TODO: verify that if hudi uses 4 bytes for checksum always.
+ // 6. bytes covered per checksum.
+ buf.putInt(DEFAULT_BYTES_PER_CHECKSUM);
Review Comment:
Yeah. # of bytes is always 4; no matter the actually number is, reader does
not use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
