wangxianghu commented on a change in pull request #2241:
URL: https://github.com/apache/hudi/pull/2241#discussion_r522020258
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -426,7 +415,7 @@ public CommandProcessorResponse
updateHiveSQLUsingHiveDriver(String sql) {
private void createHiveConnection() {
if (connection == null) {
try {
- Class.forName(HiveDriver.class.getCanonicalName());
+ Class.forName("org.apache.hive.jdbc.HiveDriver");
} catch (ClassNotFoundException e) {
Review comment:
Hi @pengzhiwei2018, thanks for your contribution.
IIUC, when you are using this feature, no matter you set
`HIVE_USE_JDBC_OPT_KEY` to true or false, the `hive-jdbc` jar has already been
included in hudi binary jar. so this pr is unnecessary.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
