yihua commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r2106124764
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/io/hadoop/TestHoodieHBaseHFileReaderWriter.java:
##########
@@ -74,20 +74,12 @@ protected HoodieAvroHFileReaderImplBase
createHFileReader(HoodieStorage storage,
protected void verifyHFileReader(byte[] content,
String hfileName,
boolean mayUseDefaultComparator,
- Class<?> expectedComparatorClazz,
int count) throws IOException {
HoodieStorage storage = HoodieTestUtils.getStorage(getFilePath());
try (HFile.Reader reader =
HoodieHFileUtils.createHFileReader(storage, new
StoragePath(DUMMY_BASE_PATH), content)) {
// HFile version is 3
assertEquals(3, reader.getTrailer().getMajorVersion());
- if (mayUseDefaultComparator && hfileName.contains("hudi_0_9")) {
- // Pre Hudi 0.10, the default comparator is used for metadata table
HFiles
- // For bootstrap index HFiles, the custom comparator is always used
- assertEquals(CellComparatorImpl.class,
reader.getComparator().getClass());
- } else {
- assertEquals(expectedComparatorClazz,
reader.getComparator().getClass());
- }
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
