linliu-code commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2110075973
##########
hudi-sync/hudi-datahub-sync/pom.xml:
##########
@@ -93,6 +93,13 @@
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
Some hdfs related test will fail, like MiniDFSCluster which is used in many
places.
##########
pom.xml:
##########
@@ -495,22 +476,6 @@
<pattern>org.apache.http.</pattern>
<shadedPattern>org.apache.hudi.org.apache.http.</shadedPattern>
</relocation>
- <!-- hbase -->
- <relocation>
- <pattern>org.apache.hadoop.hbase.</pattern>
-
<shadedPattern>org.apache.hudi.org.apache.hadoop.hbase.</shadedPattern>
- <excludes>
-
<exclude>org.apache.hadoop.hbase.KeyValue$KeyComparator</exclude>
- </excludes>
- </relocation>
- <relocation>
- <pattern>org.apache.hbase.</pattern>
- <shadedPattern>org.apache.hudi.org.apache.hbase.</shadedPattern>
- </relocation>
- <relocation>
- <pattern>org.apache.htrace.</pattern>
- <shadedPattern>org.apache.hudi.org.apache.htrace.</shadedPattern>
- </relocation>
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
