yihua commented on code in PR #13291:
URL: https://github.com/apache/hudi/pull/13291#discussion_r2110569405
##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/convert/AvroInternalSchemaConverter.java:
##########
@@ -345,14 +345,13 @@ private static Type
visitAvroPrimitiveToBuildInternalType(Schema primitive) {
} else if (logical instanceof LogicalTypes.Date) {
return Types.DateType.get();
- } else if (
- logical instanceof LogicalTypes.TimeMillis
- || logical instanceof LogicalTypes.TimeMicros) {
+ } else if (logical instanceof LogicalTypes.TimeMillis) {
+ return Types.TimeMillisType.get();
+ } else if (logical instanceof LogicalTypes.TimeMicros) {
return Types.TimeType.get();
-
- } else if (
- logical instanceof LogicalTypes.TimestampMillis
- || logical instanceof LogicalTypes.TimestampMicros) {
+ } else if (logical instanceof LogicalTypes.TimestampMillis) {
+ return Types.TimestampMillisType.get();
+ } else if (logical instanceof LogicalTypes.TimestampMicros) {
Review Comment:
Why would type handling go through the schema evolution on read here?
Supposedly the schema evolution on read logic should not be invoked by default.
Is the logic being leaked to non-schema-on-read code path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
