danny0405 commented on code in PR #13334:
URL: https://github.com/apache/hudi/pull/13334#discussion_r2110786101
##########
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieRecordUtils.java:
##########
@@ -85,11 +88,21 @@ public static HoodieRecordMerger createRecordMerger(String
basePath, EngineType
}
public static Option<HoodieRecordMerger> createValidRecordMerger(EngineType
engineType,
- String
mergerImpls, String recordMergerStrategy) {
- if
(recordMergerStrategy.equals(HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID))
{
- return Option.of(HoodieAvroRecordMerger.INSTANCE);
+ String
mergerImpls,
+ String
recordMergerStrategy) {
+ switch (recordMergerStrategy) {
+ case HoodieRecordMerger.FIRST_VALUE_MERGE_STRATEGY_UUID:
Review Comment:
> If the user already specifies the merger class, it should be the same
process as of 1.0.2.
Currently `PartialUpdateFlinkRecordMerger` uses the
`CUSTOM_MERGE_STRATEGY_UUID`, it would be great if it also works for the new
introduced mergers, so that we can get rid of these redundant strategy ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
