nsivabalan commented on code in PR #13292:
URL: https://github.com/apache/hudi/pull/13292#discussion_r2112954468
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java:
##########
@@ -351,7 +351,11 @@ public HoodieLockConfig.Builder
withHeartbeatIntervalInMillis(Long intervalInMil
}
public HoodieLockConfig.Builder
withConflictResolutionStrategy(ConflictResolutionStrategy
conflictResolutionStrategy) {
- lockConfig.setValue(WRITE_CONFLICT_RESOLUTION_STRATEGY_CLASS_NAME,
conflictResolutionStrategy.getClass().getName());
+ return
withConflictResolutionStrategyClassName(conflictResolutionStrategy.getClass().getName());
+ }
+
+ public HoodieLockConfig.Builder
withConflictResolutionStrategyClassName(String
conflictResolutionStrategyClassName) {
Review Comment:
the existing one we have is expecting a class object which is not right.
for eg, in flink we are doing new Blah() before calling
withConflictResolutionStategy(...)
In general, we should take in the class name as an argument. and hecne.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
