yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2114906617
##########
pom.xml:
##########
@@ -425,9 +424,6 @@
</excludes>
<includes>
<include>org.slf4j:slf4j-simple:*:*:test</include>
-
<include>org.apache.hbase:hbase-common:${hbase.version}</include>
Review Comment:
These exclusions are no longer needed, if relevant dependencies or files are
not introduced anyway, in which such exclusions are redundant. If so, better
to remove them to avoid confusion.
After removing these exclusion, you can build the bundles and verify that
these files do not exist, then the removal is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]