lokeshj1703 commented on code in PR #13375:
URL: https://github.com/apache/hudi/pull/13375#discussion_r2115223046
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestHoodieFileSystemViews.java:
##########
@@ -161,11 +160,7 @@ public void testFileSystemViewConsistency(HoodieTableType
tableType, boolean ena
// mimic failed write for last completed operation and retry few more
operations.
HoodieInstant lastInstant =
metaClient.reloadActiveTimeline().getWriteTimeline().lastInstant().get();
HoodieCommitMetadata commitMetadata =
metaClient.getActiveTimeline().readCommitMetadata(lastInstant);
- StoragePath instantPath = HoodieTestUtils
- .getCompleteInstantPath(metaClient.getStorage(),
- metaClient.getTimelinePath(),
- lastInstant.requestedTime(), lastInstant.getAction(),
HoodieTableVersion.fromVersionCode(writeVersion));
- metaClient.getStorage().deleteFile(instantPath);
+ client.rollback(lastInstant.requestedTime());
Review Comment:
Its not exactly mimicing a failed write. In case of a failed write, the
marker directory should still be available. Here we are just deleting the
completed commit after commit has succeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
