yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2116612184
##########
hudi-utilities/pom.xml:
##########
@@ -541,5 +541,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>javax.validation</groupId>
+ <artifactId>validation-api</artifactId>
+ <version>2.0.1.Final</version>
Review Comment:
Let's clean this up in a follow-up PR for `@NotNull`s.
##########
hudi-spark-datasource/hudi-spark3.3.x/pom.xml:
##########
@@ -243,6 +243,12 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop.version}</version>
+ </dependency>
Review Comment:
The `hudi-spark-bundle` jar does not include classes from `hadoop-common`;
that's why I'm asking why we need this now. `provided` scope should be OK and
our test environment provides `hadoop-common`.
##########
hudi-common/pom.xml:
##########
@@ -354,5 +311,9 @@
<artifactId>tally-core</artifactId>
<version>${tally.version}</version>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ </dependency>
Review Comment:
Got it. Then we need to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
