TheR1sing3un commented on code in PR #13360:
URL: https://github.com/apache/hudi/pull/13360#discussion_r2126128256
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -841,17 +841,9 @@ class HoodieSparkSqlWriterInternal {
val instantTime = executor.getInstantTime
try {
- val (writeSuccessful, compactionInstant, clusteringInstant) = mode match
{
- case _ if overwriteOperationType == null =>
- val syncHiveSuccess = metaSync(sqlContext.sparkSession, writeConfig,
basePath, df.schema)
- (syncHiveSuccess, HOption.empty().asInstanceOf[HOption[String]],
HOption.empty().asInstanceOf[HOption[String]])
- case _ =>
- try {
- commitAndPerformPostOperations(sqlContext.sparkSession, df.schema,
writeResult, parameters, writeClient, tableConfig, jsc,
- TableInstantInfo(basePath, instantTime,
executor.getCommitActionType, executor.getWriteOperationType), Option.empty)
-
- }
- }
+ val (writeSuccessful, compactionInstant, clusteringInstant) =
commitAndPerformPostOperations(
Review Comment:
<img width="1081" alt="image"
src="https://github.com/user-attachments/assets/5886bbbf-dfdf-4ed2-af87-efa4919855ee";
/>
In the previous execution logic, for the bulk insert write path that was not
overwrite, `commit` logic was included. Therefore, it only needed to perform
`meta sync`. Now I integrate all the bulk insert code paths. Currently, all the
`commit` logic is carried out here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
