zhangyue19921010 commented on code in PR #13365:
URL: https://github.com/apache/hudi/pull/13365#discussion_r2126313492


##########
pom.xml:
##########
@@ -2604,6 +2609,7 @@
         <orc.flink.version>1.5.6</orc.flink.version>
         <flink.avro.version>1.11.4</flink.avro.version>
         <flink.format.parquet.version>1.12.2</flink.format.parquet.version>
+        <parquet.version>${flink.format.parquet.version}</parquet.version>

Review Comment:
   it's about changed the parquet version for other model like 
hudi-hadoop-common. Without this config compile will failed with followed errors
   ```
   ....
     Error:  Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) 
on project hudi-hadoop-common: Compilation failure: Compilation failure: 
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[37,52]
 package org.apache.parquet.column.values.bloomfilter does not exist
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[39,33]
 package org.apache.parquet.crypto does not exist
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[40,33]
 cannot find symbol
   Error:    symbol:   class BlockCipher
   Error:    location: package org.apache.parquet.format
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[47,33]
 org.apache.parquet.hadoop.ColumnChunkPageWriteStore is not public in 
org.apache.parquet.hadoop; cannot be accessed from outside package
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[54,38]
 cannot find symbol
   Error:    symbol:   class CompressionConverter
   Error:    location: package org.apache.parquet.hadoop.util
   ...
   ```



##########
pom.xml:
##########
@@ -2604,6 +2609,7 @@
         <orc.flink.version>1.5.6</orc.flink.version>
         <flink.avro.version>1.11.4</flink.avro.version>
         <flink.format.parquet.version>1.12.2</flink.format.parquet.version>
+        <parquet.version>${flink.format.parquet.version}</parquet.version>

Review Comment:
   it's about changed the parquet version for other model like 
hudi-hadoop-common. Without this config compile will failed with followed errors
   ```
   ....
   Error:  Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) 
on project hudi-hadoop-common: Compilation failure: Compilation failure: 
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[37,52]
 package org.apache.parquet.column.values.bloomfilter does not exist
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[39,33]
 package org.apache.parquet.crypto does not exist
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[40,33]
 cannot find symbol
   Error:    symbol:   class BlockCipher
   Error:    location: package org.apache.parquet.format
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[47,33]
 org.apache.parquet.hadoop.ColumnChunkPageWriteStore is not public in 
org.apache.parquet.hadoop; cannot be accessed from outside package
   Error:  
/home/runner/work/hudi/hudi/hudi-hadoop-common/src/main/java/org/apache/hudi/parquet/io/HoodieParquetBinaryCopyBase.java:[54,38]
 cannot find symbol
   Error:    symbol:   class CompressionConverter
   Error:    location: package org.apache.parquet.hadoop.util
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to