danny0405 commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2128559522
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalog.java:
##########
@@ -480,8 +481,8 @@ public void dropPartition(ObjectPath tablePath,
CatalogPartitionSpec catalogPart
}
try (HoodieFlinkWriteClient<?> writeClient =
HoodieCatalogUtil.createWriteClient(options, tablePathStr, tablePath,
hadoopConf)) {
- writeClient.deletePartitions(Collections.singletonList(partitionPathStr),
- writeClient.createNewInstantTime())
+ String instantTime =
writeClient.startCommit(HoodieTimeline.REPLACE_COMMIT_ACTION);
Review Comment:
This is not right, the requested instant was created with empty
`HoodieRequestedReplaceMetadata`.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -822,9 +823,8 @@ public void dropPartition(
}
try (HoodieFlinkWriteClient<?> writeClient =
HoodieCatalogUtil.createWriteClient(tablePath, table, hiveConf,
this::inferTablePath)) {
boolean hiveStylePartitioning =
Boolean.parseBoolean(table.getOptions().get(FlinkOptions.HIVE_STYLE_PARTITIONING.key()));
- writeClient.deletePartitions(
-
Collections.singletonList(HoodieCatalogUtil.inferPartitionPath(hiveStylePartitioning,
partitionSpec)),
- writeClient.createNewInstantTime())
+ String instantTime =
writeClient.startCommit(HoodieTimeline.REPLACE_COMMIT_ACTION);
Review Comment:
This is not right, the requested instant was created with empty
`HoodieRequestedReplaceMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
