linliu-code commented on code in PR #13334:
URL: https://github.com/apache/hudi/pull/13334#discussion_r2128923066
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -133,15 +133,20 @@ public IndexedRecord getDeleteRow(IndexedRecord record,
String recordKey) {
}
@Override
- public Option<HoodieRecordMerger> getRecordMerger(RecordMergeMode mergeMode,
String mergeStrategyId, String mergeImplClasses) {
+ public Option<HoodieRecordMerger> getRecordMerger(RecordMergeMode mergeMode,
+ String mergeStrategyId,
+ String mergeImplClasses,
+ Option<String>
payloadClassOpt) {
switch (mergeMode) {
case EVENT_TIME_ORDERING:
- return Option.of(new HoodieAvroRecordMerger());
+ return Option.of(new EventTimeBasedAvroRecordMerger());
case COMMIT_TIME_ORDERING:
return Option.of(new OverwriteWithLatestMerger());
case CUSTOM:
default:
- Option<HoodieRecordMerger> recordMerger =
HoodieRecordUtils.createValidRecordMerger(EngineType.JAVA, mergeImplClasses,
mergeStrategyId);
+ // For custom payloads, merger class is determined by the
mergeStrategyId.
Review Comment:
Remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
