prashantwason commented on a change in pull request #2216:
URL: https://github.com/apache/hudi/pull/2216#discussion_r526142439
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java
##########
@@ -49,6 +49,12 @@
*/
private String prevCommit;
+ /**
+ * Total number of records written to the previous version of the file slice.
+ * If inflight commit is c2, then number of records present in
f1_w1_c1.parquet.
+ */
+ private long oldNumWrites;
Review comment:
@nbalajee If we move this outside of isDatalossCheckEnabled()
condition, then wont it always read the older parquet files each time before
commit? If so, there is not much to the setting anyways because the overhead of
this feature is reading the older parquet each time before merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
