danny0405 commented on code in PR #13307:
URL: https://github.com/apache/hudi/pull/13307#discussion_r2131217005
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieWriteStat.java:
##########
@@ -263,6 +272,28 @@ public void setPath(StoragePath basePath, StoragePath
path) {
this.path = path.toString().replace(basePath + "/", "");
}
+ public void putRecordsStats(Map<String,
HoodieColumnRangeMetadata<Comparable>> stats) {
+ if (!recordsStats.isPresent()) {
+ recordsStats = Option.of(stats);
+ } else {
+ // in case there are multiple log blocks for one write process.
+ recordsStats = Option.of(mergeRecordsStats(recordsStats.get(), stats));
+ }
+ }
+
+ // keep for serialization efficiency
+ public void setRecordsStats(Map<String,
HoodieColumnRangeMetadata<Comparable>> stats) {
+ recordsStats = Option.of(stats);
+ }
Review Comment:
no, putXXX has semanics for merging stats, while setXXX doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
