linliu-code commented on code in PR #13388: URL: https://github.com/apache/hudi/pull/13388#discussion_r2132487130
########## hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileReader.java: ########## @@ -46,4 +49,29 @@ protected ClosableIterator<IndexedRecord> getIndexedRecordIterator(Schema reader } public abstract ClosableIterator<IndexedRecord> getIndexedRecordIterator(Schema readerSchema, Schema requestedSchema) throws IOException; + + public abstract ClosableIterator<IndexedRecord> getIndexedRecordsByKeysIterator(List<String> keys, Review Comment: I don't see obvious difference. Let us keep the original naming until we find compelling reasons to change. ########## hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileReader.java: ########## @@ -46,4 +49,29 @@ protected ClosableIterator<IndexedRecord> getIndexedRecordIterator(Schema reader } public abstract ClosableIterator<IndexedRecord> getIndexedRecordIterator(Schema readerSchema, Schema requestedSchema) throws IOException; + + public abstract ClosableIterator<IndexedRecord> getIndexedRecordsByKeysIterator(List<String> keys, + Schema readerSchema) + throws IOException; + + public abstract ClosableIterator<IndexedRecord> getIndexedRecordsByKeyPrefixIterator( Review Comment: The same as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
