satishkotha commented on a change in pull request #2196: URL: https://github.com/apache/hudi/pull/2196#discussion_r526430857
########## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkInsertOverwriteTableCommitActionExecutor.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.table.action.commit; + +import org.apache.hudi.client.WriteStatus; +import org.apache.hudi.client.common.HoodieEngineContext; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.model.HoodieRecordPayload; +import org.apache.hudi.common.model.WriteOperationType; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.table.HoodieTable; +import org.apache.spark.api.java.JavaRDD; + +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +public class SparkInsertOverwriteTableCommitActionExecutor<T extends HoodieRecordPayload<T>> + extends SparkInsertOverwriteCommitActionExecutor<T> { + + public SparkInsertOverwriteTableCommitActionExecutor(HoodieEngineContext context, + HoodieWriteConfig config, HoodieTable table, + String instantTime, JavaRDD<HoodieRecord<T>> inputRecordsRDD) { + super(context, config, table, instantTime, inputRecordsRDD, WriteOperationType.INSERT_OVERWRITE_TABLE); + } + + @Override + protected Map<String, List<String>> getPartitionToReplacedFileIds(JavaRDD<WriteStatus> writeStatuses) { + Map<String, List<String>> result = table.getSliceView().getLatestFileSlices().distinct() Review comment: This can be time consuming for large tables. Is it possible to parallelize this? 1) get all partitions and then 2) enginecontext.parallelize(#paritions) 3) for each partition, get all latest file ids I think we dont need to add new filesystem apis with this approach ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
