the-other-tim-brown commented on code in PR #13402:
URL: https://github.com/apache/hudi/pull/13402#discussion_r2136340350
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/RecordLevelIndexTestBase.scala:
##########
@@ -131,6 +131,9 @@ class RecordLevelIndexTestBase extends
HoodieStatsIndexTestBase {
val partitionPath: String = row.getAs("_hoodie_partition_path")
val fileName: String = row.getAs("_hoodie_file_name")
val recordLocation = recordIndexMap.get(recordKey)
+ if (recordLocation == null) {
+ println("afsdf")
+ }
Review Comment:
clean this up?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestRecordLevelIndex.scala:
##########
@@ -346,6 +346,7 @@ class TestRecordLevelIndex extends RecordLevelIndexTestBase
{
@ParameterizedTest
@EnumSource(classOf[HoodieTableType])
def testRLIWithDTCleaning(tableType: HoodieTableType): Unit = {
+ val tableType = HoodieTableType.MERGE_ON_READ
Review Comment:
this looks like it is overriding the test parameter, is that intentional?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/KeyGeneratorForDataGeneratorRecords.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.io;
+
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.keygen.BuiltinKeyGenerator;
+
+import org.apache.avro.generic.GenericRecord;
+
+public class KeyGeneratorForDataGeneratorRecords extends BuiltinKeyGenerator {
Review Comment:
Isn't this the same as the simple key generator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
