yihua commented on code in PR #13407:
URL: https://github.com/apache/hudi/pull/13407#discussion_r2136727316
##########
pom.xml:
##########
@@ -1643,6 +1650,13 @@
<version>${junit.platform.version}</version>
<scope>test</scope>
</dependency>
+ <!-- Junit 4 -->
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.13.2</version>
Review Comment:
Is JUnit 4 still needed?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/index/bucket/TestBucketIdentifier.java:
##########
@@ -26,13 +26,15 @@
import org.apache.avro.Schema;
import org.apache.avro.generic.GenericData;
import org.apache.avro.generic.GenericRecord;
+import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
import java.util.Arrays;
import java.util.List;
import static org.junit.jupiter.api.Assertions.assertEquals;
+@Tag("functional")
Review Comment:
Could you double-check if this test class is categorized as functional on
master? From what I gauge based on the CI logs, this class is run under unit
tests.
<img width="1662" alt="Screenshot 2025-06-09 at 18 07 07"
src="https://github.com/user-attachments/assets/44bd9fbe-ba74-4175-9167-94cb21c28bca";
/>
<img width="1583" alt="Screenshot 2025-06-09 at 18 13 54"
src="https://github.com/user-attachments/assets/3adb8152-1ddb-4374-be6c-a15724500254";
/>
##########
pom.xml:
##########
@@ -554,6 +554,7 @@
<artifactId>apache-rat-plugin</artifactId>
<version>${apache-rat-plugin.version}</version>
<configuration>
+ <skip>true</skip>
Review Comment:
Are there RAT check failures?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/index/bucket/TestBucketIdentifier.java:
##########
@@ -26,13 +26,15 @@
import org.apache.avro.Schema;
import org.apache.avro.generic.GenericData;
import org.apache.avro.generic.GenericRecord;
+import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
import java.util.Arrays;
import java.util.List;
import static org.junit.jupiter.api.Assertions.assertEquals;
+@Tag("functional")
Review Comment:
Similar on other `@Tag("functional")` usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
