danny0405 commented on code in PR #13411:
URL: https://github.com/apache/hudi/pull/13411#discussion_r2139105703
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/KeyBasedFileGroupRecordBuffer.java:
##########
@@ -121,6 +129,18 @@ public boolean containsLogRecord(String recordKey) {
protected boolean hasNextBaseRecord(T baseRecord) throws IOException {
String recordKey = readerContext.getRecordKey(baseRecord, readerSchema);
+ int comparison;
+ while (sortOutput && !getLogRecordKeysSorted().isEmpty() && (comparison =
getLogRecordKeysSorted().peek().compareTo(recordKey)) <= 0) {
Review Comment:
either we have a separate record buffer impl (by sub-class
`KeyBasedFileGroupRecordBuffer`) or move the sorting into
`FileGroupReaderBasedAppendHandle` itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
