nsivabalan commented on code in PR #13419:
URL: https://github.com/apache/hudi/pull/13419#discussion_r2141355594
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestRecordLevelIndex.scala:
##########
@@ -229,19 +229,14 @@ class TestRecordLevelIndex extends
RecordLevelIndexTestBase {
}
@ParameterizedTest
- @CsvSource(value = Array(
- "COPY_ON_WRITE,6", "COPY_ON_WRITE,8", "MERGE_ON_READ,6", "MERGE_ON_READ,8"
- ))
- def testRLIWithDelete(tableType: String, tableVersion: Int): Unit = {
- val hudiOpts = commonOpts ++ Map(
- DataSourceWriteOptions.TABLE_TYPE.key -> tableType,
- HoodieTableConfig.VERSION.key() -> tableVersion.toString,
- HoodieWriteConfig.WRITE_TABLE_VERSION.key() -> tableVersion.toString)
+ @EnumSource(classOf[HoodieTableType])
Review Comment:
sg
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieTimeGeneratorConfig.java:
##########
@@ -47,7 +47,7 @@ public class HoodieTimeGeneratorConfig extends HoodieConfig {
.defaultValue(200L)
.withInferFunction(cfg -> {
if (DEFAULT_LOCK_PROVIDER.equals(cfg.getString(LOCK_PROVIDER_KEY))) {
- return Option.of(1L);
Review Comment:
this is source code fix right. can we move this to a separate PR.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/RecordLevelIndexTestBase.scala:
##########
@@ -35,7 +35,8 @@ import scala.util.Using
class RecordLevelIndexTestBase extends HoodieStatsIndexTestBase {
val metadataOpts: Map[String, String] = Map(
HoodieMetadataConfig.ENABLE.key -> "true",
- HoodieMetadataConfig.RECORD_INDEX_ENABLE_PROP.key -> "true"
+ HoodieMetadataConfig.RECORD_INDEX_ENABLE_PROP.key -> "true",
+ HoodieMetadataConfig.ENABLE_METADATA_INDEX_COLUMN_STATS.key -> "false"
Review Comment:
sg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
