danny0405 commented on code in PR #13422:
URL: https://github.com/apache/hudi/pull/13422#discussion_r2141488346
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java:
##########
@@ -391,6 +391,11 @@ public void releaseResources(String instantTime) {
SparkReleaseResources.releaseCachedData(context, config, basePath,
instantTime);
}
+ @Override
+ public SparkRDDWriteClient<T> createNewClient() {
+ return new SparkRDDWriteClient<>(context,
HoodieWriteConfig.newBuilder().withProperties(config.getProps()).build());
Review Comment:
But this does not work for Flink, engine like Flink can not broadcast the
write config like Spark so the server houst/port would be incorrect.
My idea is if we are confident about the write scenarios, and are sure the
embedded timeline server is enabled in the write config, we can new the write
client outside of each service and pass it instead of constructing with each
service constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
