nsivabalan commented on code in PR #13402:
URL: https://github.com/apache/hudi/pull/13402#discussion_r2145331850
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestWriteClient.java:
##########
@@ -59,9 +59,8 @@ public void
testInertsWithEmptyCommitsHavingWriterSchemaAsNull() throws Exceptio
try {
String firstCommit = "001";
int numRecords = 200;
- JavaRDD<WriteStatus> result = insertFirstBatch(cfgBuilder.build(),
client, firstCommit, "000", numRecords, SparkRDDWriteClient::insert,
+ insertFirstBatch(cfgBuilder.build(), client, firstCommit, "000",
numRecords, SparkRDDWriteClient::insert,
false, false, numRecords, INSTANT_GENERATOR);
- assertTrue(client.commit(firstCommit, result), "Commit should succeed");
Review Comment:
nope. it was intentional. insertFirstBatch already commits. and here we are
again calling explicit commit again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
