nsivabalan commented on code in PR #13402:
URL: https://github.com/apache/hudi/pull/13402#discussion_r2148864689
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkFileGroupReaderBasedMergeHandle.java:
##########
@@ -104,6 +104,8 @@ public void write() {
row.getString(HoodieRecord.RECORD_KEY_META_FIELD_ORD),
row.getString(HoodieRecord.PARTITION_PATH_META_FIELD_ORD));
HoodieSparkRecord record = new HoodieSparkRecord(recordKey, row,
sparkSchema, false);
+ record.setCurrentLocation(newRecordLocation);
+ record.setNewLocation(newRecordLocation);
Review Comment:
nope. new location is expected to be updated w/n MergeHandle.
for eg:
https://github.com/apache/hudi/blob/58191bdf5ffbf563386b69a1ac159e1436d47e57/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java#L273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
