alexr17 commented on code in PR #13264:
URL: https://github.com/apache/hudi/pull/13264#discussion_r2150253153


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -58,7 +59,8 @@ public class ArchivedTimelineV1 extends BaseTimelineV1 
implements HoodieArchived
   private static final String ACTION_STATE = "actionState";
   private static final String STATE_TRANSITION_TIME = "stateTransitionTime";
   private HoodieTableMetaClient metaClient;
-  private final Map<String, Map<HoodieInstant.State, byte[]>> readCommits = 
new HashMap<>();
+  // The first key is the timestamp -> multiple action types -> hoodie instant 
state and contents

Review Comment:
   I think v2 should be out of scope for this fix. If someone needs to read an 
older archived instant they can use the v1  timeline implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to