lw309637554 commented on a change in pull request #2136:
URL: https://github.com/apache/hudi/pull/2136#discussion_r527737700
##########
File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -255,11 +257,13 @@ private[hudi] object HoodieSparkSqlWriter {
}
if (!tableExists) {
- val archiveLogFolder = parameters.getOrElse(
- HoodieTableConfig.HOODIE_ARCHIVELOG_FOLDER_PROP_NAME, "archived")
+ val archiveLogFolder =
parameters.get(HoodieTableConfig.HOODIE_ARCHIVELOG_FOLDER_PROP_NAME).get
Review comment:
this is because in HoodieIndexUtils.getIndexType will also get the
INDEX_TYPE_PROP , and should add "parameters.getOrElse(
HoodieIndexConfig.INDEX_TYPE_PROP,
HoodieIndexConfig.DEFAULT_INDEX_TYPE)" here. as your comment ,can move the two
param init to HoodieWriterUtils. parametersWithWriteDefaults
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
