n3nash commented on a change in pull request #2263:
URL: https://github.com/apache/hudi/pull/2263#discussion_r528044975
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -726,6 +751,54 @@ private void rollbackPendingCommits() {
return compactionInstantTimeOpt;
}
+ /**
+ * Schedules a new clustering instant.
+ *
+ * @param extraMetadata Extra Metadata to be stored
+ */
+ public Option<String> scheduleClustering(Option<Map<String, String>>
extraMetadata) throws HoodieIOException {
+ String instantTime = HoodieActiveTimeline.createNewInstantTime();
+ return scheduleClusteringAtInstant(instantTime, extraMetadata) ?
Option.of(instantTime) : Option.empty();
+ }
+
+ /**
+ * Schedules a new clustering instant with passed-in instant time.
+ *
+ * @param instantTime clustering Instant Time
+ * @param extraMetadata Extra Metadata to be stored
+ */
+ public boolean scheduleClusteringAtInstant(String instantTime,
Option<Map<String, String>> extraMetadata) throws HoodieIOException {
+ LOG.info("Scheduling clustering at instant time :" + instantTime);
+ Option<HoodieClusteringPlan> plan = createTable(config, hadoopConf)
+ .scheduleClustering(context, instantTime, extraMetadata);
+ return plan.isPresent();
+ }
+
+ /**
+ * Ensures clustering instant is in expected state and performs clustering
for the plan stored in metadata.
+ *
+ * @param clusteringInstant Clustering Instant Time
+ * @return Collection of Write Status
+ */
+ protected abstract HoodieWriteMetadata<O> cluster(String clusteringInstant,
boolean shouldComplete);
+
+ /**
+ * Executes a clustering plan on a table, serially before or after an
insert/upsert action.
+ */
+ protected Option<String> inlineCluster(Option<Map<String, String>>
extraMetadata) {
+ Option<String> clusteringInstantOpt = scheduleClustering(extraMetadata);
+ clusteringInstantOpt.ifPresent(clusteringInstant -> {
+ // inline cluster should auto commit as the user is never given control
+ cluster(clusteringInstant, true);
+ });
+ return clusteringInstantOpt;
+ }
+
+ public void rollbackInflightClustering(HoodieInstant inflightInstant,
HoodieTable<T, I, K, O> table) {
Review comment:
Should this be a public method ? Rolling back inflight could probably
remain private ? Or is this for the CLI ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
