zhangyue19921010 commented on code in PR #13365:
URL: https://github.com/apache/hudi/pull/13365#discussion_r2156505752
##########
hudi-common/src/main/java/org/apache/hudi/common/bloom/InternalDynamicBloomFilter.java:
##########
@@ -210,13 +210,29 @@ public void readFields(DataInput in) throws IOException {
/**
* Adds a new row to <i>this</i> dynamic Bloom filter.
*/
- private void addRow() {
+ protected void addRow() {
InternalBloomFilter[] tmp = new InternalBloomFilter[matrix.length + 1];
System.arraycopy(matrix, 0, tmp, 0, matrix.length);
tmp[tmp.length - 1] = new InternalBloomFilter(vectorSize, nbHash,
hashType);
matrix = tmp;
}
+ protected void addRows(int size) {
Review Comment:
added TestInternalDynamicBloomFilter#testInternalDynamicBloomFilterRescale
which cover `rescaleFromTarget`, `getMatrixLength` and `addRows`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
