[
https://issues.apache.org/jira/browse/HUDI-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Chen closed HUDI-9531.
----------------------------
Reviewers: Danny Chen
Resolution: Fixed
Fixed via master branch: 07d176e2d462d8ff83658caba23d15938d0de719
> Avoid generating timestamp again in createCompleteFileInMetaPath
> ----------------------------------------------------------------
>
> Key: HUDI-9531
> URL: https://issues.apache.org/jira/browse/HUDI-9531
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: Vinish Reddy
> Assignee: Vinish Reddy
> Priority: Minor
> Fix For: 1.1.0
>
>
> There's an issue in the completion generation time code. We don't use
> currentTimeMillis coming from the skew adjusting time generator and generate
> a new time.
> timeGenerator.consumeTime(!shouldLock, currentTimeMillis -> { String
> completionTime = TimelineUtils.generateInstantTime(false, timeGenerator);
> String fileName = instantFileNameGenerator.getFileName(completionTime,
> instant);
> There's no issue in correctness but yeah we are generating a new timestamp
> without a need for it and can be avoided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
