the-other-tim-brown commented on code in PR #13469:
URL: https://github.com/apache/hudi/pull/13469#discussion_r2159375663
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -158,16 +158,12 @@ private HoodieFileGroupReader(HoodieReaderContext<T>
readerContext, HoodieStorag
? new PositionBasedSchemaHandler<>(readerContext, dataSchema,
requestedSchema, internalSchemaOpt, tableConfig, props)
: new FileGroupReaderSchemaHandler<>(readerContext, dataSchema,
requestedSchema, internalSchemaOpt, tableConfig, props));
this.outputConverter =
readerContext.getSchemaHandler().getOutputConverter();
- this.orderingFieldName = recordMergeMode ==
RecordMergeMode.COMMIT_TIME_ORDERING
- ? Option.empty()
- : Option.ofNullable(ConfigUtils.getOrderingField(props))
Review Comment:
Currently the developer can override how the events are ordered by passing a
prop that does not match the table config. This seems risky so I am changing
this to use the table config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
