the-other-tim-brown commented on code in PR #13451:
URL: https://github.com/apache/hudi/pull/13451#discussion_r2164165406
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1789,12 +1789,10 @@ void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O>
writeClient, Option<Strin
writeClient.compact(compactionInstantTime, true);
} else if (metadataWriteConfig.isLogCompactionEnabled()) {
// Schedule and execute log compaction with new instant time.
- final String logCompactionInstantTime =
metadataMetaClient.createNewInstantTime(false);
- if
(metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(logCompactionInstantTime))
{
- LOG.info("Log compaction with same {} time is already present in the
timeline.", logCompactionInstantTime);
Review Comment:
Right now we are assuming the skew guarantees uniqueness across jvms,
uniqueness within a jvm is guaranteed by `HoodieInstantTimeGenerator`. I'm not
sure how this condition would return true currently. It mainly looks like it is
copied from the compaction case where the the instant time can be manually
generated to by just before the last inflight commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
