liujinhui1994 commented on a change in pull request #2242:
URL: https://github.com/apache/hudi/pull/2242#discussion_r528440808
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -522,14 +523,18 @@ public static void main(String[] args) throws Exception {
*/
private transient DeltaSync deltaSync;
+ private final HoodieDeltaStreamerConfig deltaStreamerConfig;
+
public DeltaSyncService(Config cfg, JavaSparkContext jssc, FileSystem fs,
Configuration conf,
Option<TypedProperties> properties) throws
IOException {
+ this.props = properties.get();
this.cfg = cfg;
this.jssc = jssc;
this.sparkSession =
SparkSession.builder().config(jssc.getConf()).getOrCreate();
this.asyncCompactService = Option.empty();
+ this.deltaStreamerConfig = new HoodieDeltaStreamerConfig(props);
- if (fs.exists(new Path(cfg.targetBasePath))) {
+ if (fs.exists(new Path(cfg.targetBasePath)) &&
!deltaStreamerConfig.getFullOverwrite()) {
Review comment:
1.'deltaStreamerConfig.getFullOverwrite()' is only for dfsSouce, is it
inappropriate to put it in the delta streamer command-line tool?
2. There are more and more deltastreamer configurations, we can manage these
in one class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
