danny0405 commented on code in PR #13476:
URL: https://github.com/apache/hudi/pull/13476#discussion_r2167927064
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/common/HoodieFlinkEngineContext.java:
##########
@@ -218,6 +222,12 @@ public ReaderContextFactory<?>
getReaderContextFactory(HoodieTableMetaClient met
return (ReaderContextFactory<?>)
ReflectionUtils.loadClass("org.apache.hudi.table.format.FlinkReaderContextFactory",
metaClient);
}
+ public void dropIndex(HoodieConfig config, List<String> metadataPartitions) {
+ try (BaseHoodieWriteClient client = new HoodieFlinkWriteClient(this,
(HoodieWriteConfig) config)) {
Review Comment:
1. the `#dropIndex` does not belong here;
2. use `SupportsUpgradeDowngrade#getWriteClient` to fetch the write client;
3. be caution to the write config we used in 2 while constructing the write
client to avoid starting the embedded timeline servier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
