voonhous commented on code in PR #13481:
URL: https://github.com/apache/hudi/pull/13481#discussion_r2168019357
##########
hudi-common/src/main/java/org/apache/hudi/expression/Predicates.java:
##########
@@ -120,6 +121,19 @@ public <T> T accept(ExpressionVisitor<T> exprVisitor) {
public String toString() {
return "TRUE";
}
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
Was performing unit testing in Trino and realised that `assertEquals` are
failing when checking ExpressionIndex correctness.
`p1.toString.equals(p2.toString)` works and we are using that now. For the
sake of robustness, I've decided to raise this PR to include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
