danny0405 commented on code in PR #13216:
URL: https://github.com/apache/hudi/pull/13216#discussion_r2167993933
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -284,7 +284,10 @@ protected void commit(HoodieTable table, String
commitActionType, String instant
}
// update Metadata table
writeTableMetadata(table, instantTime, metadata);
- activeTimeline.saveAsComplete(false,
table.getMetaClient().createNewInstant(HoodieInstant.State.INFLIGHT,
commitActionType, instantTime), Option.of(metadata));
+ activeTimeline.saveAsComplete(false,
+ table.getMetaClient().createNewInstant(HoodieInstant.State.INFLIGHT,
commitActionType, instantTime), Option.of(metadata),
+ completedInstant ->
table.getMetaClient().getTableFormat().commit(metadata, completedInstant,
getEngineContext(), table.getMetaClient(), table.getViewManager())
Review Comment:
+1, and the logic looks redundant to Hoodie beause the `#commit` for hoodie
too, I didn't quite get what a table format commit for hoodie means, my
understanding is the `#activeTimeline.saveAsComplete` itself is already a
"table format commit" for hoodie.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
