yui2010 commented on pull request #2243:
URL: https://github.com/apache/hudi/pull/2243#issuecomment-732133438
hi, garyli1019
thanks for your review
1. "getting a basepath instead of basePath in the map"
the map is a CaseInsensitiveMap
(https://github.com/apache/spark/blob/v2.4.4/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala)
it store lowercase key . it will return correct value when call its get method
2. "the user defined query type will be replaced by the
DEFAULT_QUERY_TYPE_OPT_VAL"
i missed the logic . and i changed it in translateViewTypesToQueryTypes
method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
